Re: [PATCH] Wrap earlier in horizontal icon container layout

On Sun, 2005-09-11 at 00:47 +0200, Christian Neumair wrote:
> The proposed attached patch fixes bug 313025 [1] by ensuring a margin of
> 8 on the right side of the icons.
> [1]

Is this really the right fix?
It seems like what the patch adds is the guarantee that there will
always be an empty area of 8 pixels to the right of all icons, whereas
the bug seems to be that the icons actually go outside the right edge.
Now, it of course helps cover this bug if we always add 8 blank pixels,
but aren't we papering over the real problem, and if we have this bug
won't it cause us to get less than 8 blank pixels on the right? 

Imho we alreay have much blank space in the icon view, and we linewrap
to early in almost all cases. I think its a bad idea to add another 8
pixels on the side.

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a lounge-singing playboy card sharp trapped in a world he never made. 
She's a transdimensional punk socialite with the soul of a mighty warrior. 
They fight crime! 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]