Re: [PATCH] Wrap earlier in horizontal icon container layout

Am Montag, den 19.09.2005, 16:05 +0200 schrieb Alexander Larsson:
> On Sun, 2005-09-11 at 00:47 +0200, Christian Neumair wrote:
> > The proposed attached patch fixes bug 313025 [1] by ensuring a margin of
> > 8 on the right side of the icons.
> > 
> > [1]
> Is this really the right fix?
> It seems like what the patch adds is the guarantee that there will
> always be an empty area of 8 pixels to the right of all icons,


> whereas the bug seems to be that the icons actually go outside the right edge.

No. The patch complains that scrolling starts if the
window_width-edge_of_rightmost_icon \in [0;ICON_PAD_RIGHT].

> Imho we alreay have much blank space in the icon view, and we linewrap
> to early in almost all cases.

Maybe you could line out how wrapping should work ideally? I don't think
it is a good idea to reduce the icon hspacing and margins if there isn't
enough space for the right column.

Christian Neumair <chris gnome-de org>

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]