Re: [PATCH] Make desktop_is_home_dir preference changes instant apply

On Wed, 2005-09-07 at 23:55 +0200, Christian Neumair wrote:
> Also covered by bug 116217 [1]. Since users typically set this once, I
> think it would be quiet nice to give instant feedback to show them what
> they actually changed.
> [1]

-	/* We don't invalidate the files in desktop, since they are always
-	   up to date. (And we don't ever want to mark them invalid.) */
+	nautilus_directory_force_reload_internal (NAUTILUS_DIRECTORY (desktop),
+						  nautilus_file_get_all_attributes ());

Why did you change this? I don't believe this should be needed, and it
worries me. I don't remember all the details about
NautilusDesktopIconFile exactly, but I don't think invalidating
attributes for them are right at all, and i'm not sure they'll ever be
validated again.

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a bookish umbrella-wielding dog-catcher on the edge. She's a cold-hearted 
gold-digging mechanic with the soul of a mighty warrior. They fight crime! 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]