Re: [PATCH] Improve backup file experience

On Wed, 2005-09-07 at 19:24 +0200, Christian Neumair wrote:
> The attached patch takes care that the GConf key
> "/desktop/gnome/file_views/show_backup_files" takes effect independently
> from the GConf key "/desktop/gnome/file_views/show_hidden_files". We
> used to decide whether to display backup files based on whether to
> display hidden files. With these changes, one can effectively see his
> backup files, while still hiding the hidden files.

I don't think this is the right approach. Once upon a time we had two
global prefs, "show hidden" and "show backup". At one point we cleared
up the ui to only contain one UI element that controlled both of these,
although you could still set them separately manually. A bit later we
added a per-window show hidden files preference. The way this works is
that the global setting is the default, and unless you specifically
changed the settings in a window that window will continue to follow the
global setting. However, the new per-window setting is only one setting,
not two (hidden + backup).

This patch makes it impossible to view backup files in a window by using
the "View -> Show hidden files" menu item, as the backup setting always
follows the global setting. If I use that menu item I expect all files
that are not currently showing to become visible.

I think separating hidden and backup file preferences in the ui is a
mistake, since this complicates the UI for little gain. Few people
appreciate the difference. We can keep the split for the default
settings, but the per-window preference should control both backup files
and hidden files.

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a maverick drug-addicted cowboy who knows the secret of the alien 
invasion. She's an elegant gypsy schoolgirl trying to make a difference in a 
man's world. They fight crime! 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]