Re: [PATCH] Autofill "Connect To Server" when already in a remote location
- From: Alexander Larsson <alexl redhat com>
- To: nielsen memberwebs com
- Cc: Nautilus List <nautilus-list gnome org>
- Subject: Re: [PATCH] Autofill "Connect To Server" when already in a remote location
- Date: Mon, 19 Sep 2005 15:17:39 +0200
On Wed, 2005-09-07 at 23:49 +0000, Nate Nielsen wrote:
> As a convenience feature, if I'm at a window displaying a remote
> location (URI) in nautilus, and then choose 'Connect to Server' from the
> menu, it should fill in that URI by default.
>
> In these cases this patch selects 'Custom Location' and enters the URI.
> Note that usability is not affected as most users will generally choose
> 'Connect to Server' from the 'Places' menu or their Home Folder or some
> such.
>
> Bug: http://bugzilla.gnome.org/show_bug.cgi?id=314745
> Patch: http://bugzilla.gnome.org/attachment.cgi?id=51488&action=view
>
> Okay to commit? Or is the freeze still on?
Its sort of strange the way you pass the uri via a property. Just add a
new argument to nautilus_connect_server_dialog_new() instead.
Also, gnome_vfs_uri_is_local() is the wrong call, as it returns FALSE
for e.g. nfs shares. Just look for file: uris instead. You should
probably filter out more locations, like network:, burn:, fonts:.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's an obese playboy sorceror gone bad. She's a violent psychic advertising
executive living homeless in New York's sewers. They fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]