Re: [PATCH] Access location popup menu from pathbar

[Alexander Larsson <alexl redhat com>]

On Wed, 2005-07-20 at 14:41 +0200, Christian Neumair wrote:
> Am Donnerstag, den 14.07.2005, 15:21 +0200 schrieb Alexander Larsson:
> > On Thu, 2005-07-14 at 13:11 +0200, Christian Neumair wrote:
> > > Am Mittwoch, den 13.07.2005, 10:57 +0200 schrieb Alexander Larsson:
> > > > On Sun, 2005-07-10 at 15:39 +0200, Christian Neumair wrote:
> > > > > From bug 309844 [1]:
> > > > > 
> > > > > "In spatial nautilus, it is possible to access the currently displayed
> > > > > folder's right-click menu from the location button (lower left). From
> > > > > there you can act on the opened menu (cut/copy, open properties, etc).
> > > > > 
> > > > > It would be nice to be able to access the same menu directly from the
> > > > > path bar in a browser window."
> > > > > 
> > > > > Proposed patch attached. Note that its architecture theoretically allows
> > > > > that the gtk_toggle_button_get_active check in
> > > > > path_bar_button_pressed_callback is removed and a location menu is
> > > > > generated for all locations displayed in the pathbar - but we'd have to
> > > > > adapt nautilus_view_pop_up_location_context_menu to optionally take a
> > > > > location for which the menu should be generated.
> > > > > 
> > > > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=309844
> > > > 
> > > > I dunno. Its very strange that it only works for the current directory
> > > > button.
> > > 
> > > Isn't it better than nothing at all? For now the most important thing is
> > > IMHO to be able to change the viewed containers' properties.
> > 
> > I don't think adding something that feels internally inconsistent is
> > good. Is it better than nothing? I dunno, but I think a non-internaly
> > inconsistent solution is much better, and quite doable. If we add one
> > solution now it will end up much harder to come with a right solution
> > later.
> 
> Proposed patch #2 attached. Maybe sb. else finds the time to review it
> while you're away.

This doesn't seem to apply anymore. Some comments:

The way you get the right click events on the buttons in the pathbar is
very strange. You create a new signal, and when that is fired you walk
the internals of the widget and add signal handlers. Why not just create
a new signal in the pathbar widget that fires when you right click
somewhere.

Does the popup menu part really work well? The current code relies on
view->details->directory_as_file being monitored and thus the
NautilusFile up-to-date for the menu work. If you pass in any random
location this might not be true.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a lounge-singing guerilla farmboy in a wheelchair. She's a cosmopolitan 
antique-collecting Hell's Angel who hides her beauty behind a pair of 
thick-framed spectacles. They fight crime!