Re: Thumbnail cleanup UI patch (bug 150483)

[pHilipp Zabel <philipp zabel gmail com>]

On 5/2/05, Alexander Larsson <alexl redhat com> wrote:
> On Thu, 2005-04-28 at 16:35 +0200, pHilipp Zabel wrote:
> > libnautilus-private/nautilus-file-operations.c: in
> > sync_transfer_callback, line 1708:
> >
> >               case GNOME_VFS_XFER_PHASE_DELETESOURCE:
> >                       g_assert (progress_info->source_name != NULL);
> >                       if (progress_info->top_level_item) {
> >                               nautilus_file_changes_queue_schedule_metadata_remove
> >                                       (progress_info->source_name);
> >                       }
> >                       nautilus_file_changes_queue_file_removed (progress_info->source_name);
> >                       break;
> >
> > I don't understand why progress_info->top_level_item is always
> > zero here, even if I'm shift-deleting a single file. It seems that
> > nautilus_file_changes_queue_schedule_metadata_remove is
> > just never called?
> 
> What if you move a file, is it called then?

If I move files, GNOME_VFS_XFER_PHASE_DELETESOURCE is never reached.
I believe that in this case,
nautilus_file_changes_queue_schedule_metadata_remove
is called in the GNOME_VFS_XFER_PHASE_OPENTARGET case, but I'm still in
the progress of littering the code with g_message()s, hoping to
understand what's going on.

pHilipp