Re: [PATCH] Drop text in Nautilus window, new file created

[Alexander Larsson <alexl redhat com>]

On Thu, 2005-06-23 at 22:07 +0200, Christian Neumair wrote:
> Am Dienstag, den 07.06.2005, 11:36 +0200 schrieb Alexander Larsson:

> > +			      NULL, NULL,
> > +			      nautilus_marshal_VOID__STRING_INT_INT_INT,
> > +			      G_TYPE_NONE, 4,
> > +			      G_TYPE_STRING,
> > +			      G_TYPE_INT,
> > +			      G_TYPE_INT,
> > +			      G_TYPE_INT);
> > 
> > This looks wrong. There is only two int args. The others seem wrong too.
> 
> Right, I've fixed the marshallers to take a GDK_TYPE_ACTION as the first
> element of the action/x/y triple.

Eh? GdkAction? 

Where in e.g:
void	     (* handle_url)		  (NautilusIconContainer *container,
					   char *url,
					   int x,
					   int y);
or
+void	     (* handle_text)		  (NautilusIconContainer *container,
+					   char *text,
+					   int x,
+					   int y);

is the GdkAction?

Also:

+		target_filename = gnome_vfs_uri_extract_short_name (source_uri);
+		target_uri = gnome_vfs_uri_append_file_name (parent_uri, target_filename);
+		g_free ((char *) target_filename);

This unnecessary re-uses a (const) argument as a (non-const!) local variable.


=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a witless native American dwarf with a winning smile and a way with the 
ladies. She's a scantily clad bisexual angel from the wrong side of the 
tracks. They fight crime!