Re: [PATCH] Fix pathbar history issue

On Tue, 2005-07-12 at 17:36 +0200, Christian Neumair wrote:
> From bug 310068 [1]:
> "Steps to reproduce the problem:
> 1. Enter a folder with lots of stuff in it so that the scroll bar
> appears
> 2. Scroll down a bit, then enter a sub-folder
> 3. Use the path bar to go back to the previous folder
> Actual Results:
> Scroll bar is at the beginning ot the parent folder.
> Expected Results:
> Scroll bar is at the position I scrolled to prior to entering the
> sub-folder."
> Proposed patch attached. I've fixed this by treating a pathbar location
> change as back action if the target location is in the history.

+       bookmark = nautilus_bookmark_new (uri, "foo");

Creating a bookmark like that does all sorts of i/o, which can cause
authentication and whatnot on a too early state. Instead, just get the
uri from the bookmark and compare it.

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a globe-trotting small-town card sharp haunted by memories of 'Nam. She's 
a virginal junkie stripper with a song in her heart and a spring in her step. 
They fight crime! 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]