Re: [PATCH] Display hostname in copy/move progress dialog for non-local URIs



Am Donnerstag, den 07.07.2005, 09:56 +0200 schrieb Alexander Larsson:
> On Wed, 2005-07-06 at 14:43 +0200, Christian Neumair wrote:
> > Am Mittwoch, den 06.07.2005, 13:18 +0200 schrieb Alexander Larsson:
> > > On Mon, 2005-07-04 at 16:56 +0200, Christian Neumair wrote:
> > > > I've noticed that moving data from/to my ssh machine to/from localhost
> > > > with Nautilus may cause confusion, since I use the same login on both
> > > > computers. Sometimes it isn't obvious whether I copy from or to the ssh
> > > > machine. The attached patch fixes this by telling the user what machine
> > > > he moves/copies from/to in the progress dialog, at least if the URI is
> > > > not local.
> > > 
> > > gnome_vfs_uri_is_local() doesn't do what you think it does. You need to
> > > check for file:/// uris.
> > 
> > Proposed patch #2 attached.
> 
> Looks good to me.

Done.

> Also, this is a string change, so you have to announce it to the i18n people.

While it is a string change, it does not break any strings. The string
"%s on %s" is used with exactly the same meaning in various other
locations (remote window title, etc.).

-- 
Christian Neumair <chris gnome-de org>

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]