Re: [PATCH] - New sidepanel plug-in for Gtk bookmarks and places

[Alexander Larsson <alexl redhat com>]

On Thu, 2005-06-30 at 16:49 +0100, Jamie McCracken wrote:
> Alexander Larsson wrote:
> 
> >>vpane makes more sense IMO - user gets to control it but the tree view 
> >>already suffers from lack of space anyway so this will just make it 
> >>worse. Still it offers a way to split out the tree view from the places 
> >>if the lower pane always shows the hierarchical tree for the current 
> >>location (without any places) and the upper pane just the non-expandable 
> >>places and volumes.
> > 
> > 
> > Yeah, this is probably the best approach for this. Can you experiment
> > with that a bit?
> > 
> > If it doesn't work out well I guess the places sidebar makes more sense.
> 
> One thing that does work very well with a places sidebar is the new 
> hierarchical list view (which absolutely rocks - we need this in 
> GTKFileChooser too!). I find tree folder navigation much more usable in 
> that view as it is no longer space constrained.
> 
> I dont mind experimenting if you feel its worth it but it would almost 
> certainly pale in comparison to the above in terms of usability. Any 
> chance of accepting the places sidebar without experimenting?

I did some experimenting with this, and it seems like having a places
sidebar is really the best solution. So, since there string/ui change
announcement starts after I release tarballs later today I decided to
get this in before doing the release. I cleaned up the code, fixing
various leaks, simplifying things, etc. Unfortunately I accidentally
lost the review notes, so I can't tell you exactly what.

I removed the add/remove buttons, because those functions are already
availible in the ui, and the buttons were using far to much window space
compared to how often they are used.

The sidebar still needs some work though, and it would be nice if you
could look into doing this. At the least I'd like it to support:

* DnD of file onto row => copy file there
* DnD of folder to empty space => add bookmark
* Context menu on the rows with operations like: 
  - eject for volumes
  - rename for bookmarks
  - delete for bookmarks

Also, maybe the trash should be in the sidebar?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an otherworldly vegetarian gangster She's a vivacious out-of-work widow 
who inherited a spooky stately manor from her late maiden aunt. They fight 
crime!