Re: [PATCH] - New sidepanel plug-in for Gtk bookmarks and places

[Luca Ferretti <elle uca libero it>]

Il giorno gio, 30/06/2005 alle 14.09 +0200, Jakub Steiner ha scritto:
> On Tue, 2005-06-28 at 15:21 +0200, Alexander Larsson wrote:
> 
> > > See my new blog for further info and screenshots:
> > > http://www.advogato.org/person/jamiemcc/diary.html?start=0
> > 
> > I must say i don't understand this at all. Its basically the tree view
> > without any features, but with the bookmarks visible always and a couple
> > of button taking up a lot of space for functions that are easily
> > accessible in the menu already.
> > 
> > What is the usecase for this?
> 
> Hi Alex,
> The full tree view requires a lot of screen estate and is very clumsy
> for a side bar, requiring lots of scrolling in almost all my cases. The
> default locations + bookmarks proved to be very efficient for me in the
> file chooser.
> 
> I would also suggest replacing the URI bar with the button structure as
> featured in the file dialog. 


/me agrees. Both Places sidepane and button location bar are must have
feature. Provide a common interface for file selection and navigation
file manager is a Good Thing(TM).

About the patch, please note that (at least in my installation):
      * It seems that the Places sidepane uses the gtk backend insted
        gnomevfs one (I'm using nautilus head over gnome-vfs 2.10 and
        gtk+ 2.6)
      * Icons in Places sidepane seems scaled down from 48x48: use the
        correct icon size
      * Add and Remove buttons are just a waste of space in a Nautilus
        window: if you like to add a Place to this list you can use the
        Bookmark->Add Bookmark menu item, as well as to remove you can
        use the Edit Bookmark dialog[1]

Moreover, not strictly related to this patch but about recent Nautilus
support to gtk-bookmarks:
      * The gtk-bookmark's locations listed in Places menu for spatial
        windows aren't at GTK_ICON_SIZE_MENU (or whatever is its name)
      * Same for the items in Bookmarks menu in navigation windows
      * "Add Bookmark" and "Edit Bookmarks" menu entries could use stock
        icons stock_add-bookmark and stock_edit-bookmarks
      * Maybe we need to re-label those entries... "Remember Location"
        and "Edit Places", maybe??
      * Maybe remove the Bookmark menu in navigational windows and
        replace it whit the Places one from spatial windows (see Go menu
        items too)?


[1] IMHO the Places sidepane should 
     1. support d'n'd as well as all other nautilus items: you should be
        able to drop here folders to add them to the list as well as you
        should be able to drop the location currently showed in the
        navigation window to add it to the list
     2. provide a popup menu like with "Add Current Location" "Edit
        Bookmarks" and "Remove Location" entries. The last one should be
        available only when you right click over a removable entri of
        the Places list.
     3. Allow unmount/eject of removable device (yeah, it's very OSX
        like, but I suspect that if we'll add the Place sidepane,
        someone will ask for this feature :-)