Re: Warning on empty trash [was Re: feature freeze]



Il giorno lun, 24-01-2005 alle 10:44 +0100, Alexander Larsson ha
scritto: 
> On Mon, 2005-01-24 at 10:41 +0100, Paolo Borelli wrote:
> > Il giorno lun, 24-01-2005 alle 10:26 +0100, Alexander Larsson ha
> > scritto:
> > > > 
> > > > Using the new MessageDialog API? See attachment.
> > > 
> > > Commited. Thanks.
> > > 
> > 
> > AFAICS the patch removes the GTK_STOCK_DELETE icon from the "Empty
> > Trash" button... it may have been intentional, just pointing it out.
> 
> I noticed this too, but I didn't really care (assuming some hig thing).
> Luca, was this intentional?

It was a lapsus calami[1]. I feel wrong the GTK_STOCK_DELETE icon here,
so I removed it unconsciously. 

My point of view is: we have 2 menu items MoveToTrash and Delete.
MoveToTrash has GTK_STOCK_DELETE as icon. Delete has no icon. Delete and
EmptyTrash perform the same action. To use GTK_STOCK_DELETE for
EmtpyTrash is wrong.[2]


[1] slip of the pen
[2] sorry, I'm very tired now. My best argument now is "tree good, fire
bad".
-- 
Luca Ferretti <elle uca libero it>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]