Re: Warning on empty trash [was Re: feature freeze]

[Dennis Cranston <dennis_cranston yahoo com>]

--- Alexander Larsson <alexl redhat com> wrote:

> On Fri, 2005-01-21 at 17:07 +0100, Luca Ferretti wrote:
> > Il giorno ven, 21-01-2005 alle 15:02 +0100, Alexander Larsson ha
> > scritto:
> > > On Fri, 2005-01-21 at 12:51 +0100, Luca Ferretti wrote:
> > > > Il giorno ven, 21-01-2005 alle 11:42 +0100, Alexander Larsson ha
> > > > scritto:
> > > > > We're currently in a feature freeze. The difference between fixing a bug
> > > > > and adding a feature is sometimes small, and some of the latest patches
> > > > > I've been committing  could be argued to be features. Since I was away
> > > > > for such a long time during the non-feature-frozen period I've been a
> > > > > bit lenient about this until now.
> > > > > 
> > > > > However, from now we need to take the feature freeze seriously and
> > > > > mainly work on fixing actual bugs.
> > > > 
> > > > What about change GTK_DIALOG_QUESTION in GTK_DIALOG_WARNING for
> > > > confirmation alerts? I.e. for the empty trash confirmation?
> > > > 
> > > > Note that HIG suggest the warning icon [1], while currently a lot of
> > > > GNOME projects still use the question one.
> > > 
> > > What about it? It sounds like a bugfix to me.
> > 
> > Using the new MessageDialog API? See attachment.
> 
> Commited. Thanks.
> 

One verbage fix is needed.  In the secondary text the word "sepately" should be "separately". 
Also, you might want to send a patch to the maintainers of the trash applet.  They use a similar
dialog.