Re: Warning on empty trash [was Re: feature freeze]

[Alexander Larsson <alexl redhat com>]

On Fri, 2005-01-21 at 17:07 +0100, Luca Ferretti wrote:
> Il giorno ven, 21-01-2005 alle 15:02 +0100, Alexander Larsson ha
> scritto:
> > On Fri, 2005-01-21 at 12:51 +0100, Luca Ferretti wrote:
> > > Il giorno ven, 21-01-2005 alle 11:42 +0100, Alexander Larsson ha
> > > scritto:
> > > > We're currently in a feature freeze. The difference between fixing a bug
> > > > and adding a feature is sometimes small, and some of the latest patches
> > > > I've been committing  could be argued to be features. Since I was away
> > > > for such a long time during the non-feature-frozen period I've been a
> > > > bit lenient about this until now.
> > > > 
> > > > However, from now we need to take the feature freeze seriously and
> > > > mainly work on fixing actual bugs.
> > > 
> > > What about change GTK_DIALOG_QUESTION in GTK_DIALOG_WARNING for
> > > confirmation alerts? I.e. for the empty trash confirmation?
> > > 
> > > Note that HIG suggest the warning icon [1], while currently a lot of
> > > GNOME projects still use the question one.
> > 
> > What about it? It sounds like a bugfix to me.
> 
> Using the new MessageDialog API? See attachment.

Commited. Thanks.

> Note 2 eel-stock-dialogs.h is used deeply in nautilus. Maybe a target
> for the next release could be drop out this dependance and move to
> GtkMessageDialog or at lease use GtkMessageDialog in eel-alert-dialog.c
> and provide HIG compliant alerts.

While this might be nice, its hardly a blocker bug in any sense. If
someone wants to do this that would be cool of course.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a notorious drug-addicted hairdresser moving from town to town, helping 
folk in trouble. She's an artistic Bolivian traffic cop with the soul of a 
mighty warrior. They fight crime!