Re: "Connect to Server" dialog & new panel menu layout

[Alexander Larsson <alexl redhat com>]

On Thu, 2005-01-13 at 20:02 +0100, Vincent Untz wrote:
> Hi,
> 
> Le jeudi 13 janvier 2005 à 14:45 +0100, Alexander Larsson a écrit :
> > On Wed, 2005-01-12 at 19:20 +0100, Vincent Untz wrote:
> > > Here we go. Patch is attached.
> > > 
> > > Some comments:
> > >    * I did not call nautilus_module_init(). Is it needed?
> > No.
> > 
> > >    * I couldn't think of a better way than all the #ifdefs...
> > 
> > Does those work at all? I would assume that
> > nautilus-connect-server-dialog.o only get built once. Can't you pass it
> > a NULL for the NautilusWindow, and then create your own
> > nautilus_application_present_spatial_window() in
> > nautilus-connect-server-dialog-main.c that uses
> > gnome_url_show_on_screen().
> 
> New patch is attached. I made the patch less intrusive.
> 
> However, I don't see how nautilus-connect-server-dialog.o can only get
> built once: to use another
> nautilus_application_present_spatial_window(), I need to define it
> somewhere. So there'll be a conditional include...
> 
> The other way I can do it is #include "nautilus-connect-server-dialog.c"
> in nautilus-connect-server-dialog-main.c... Hacky way, but should work.

I re-did this a bit differently to not require the ifdef. Check it out.
gnome-vfs seems to crash for me when i try to open a non-local spatial
window using this though.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scrappy gay gangster on his last day in the job. She's a ditzy snooty 
magician's assistant with someone else's memories. They fight crime!