Re: [PATCH] Show icons for trash, cd burner and computer

Luca Ferretti wrote:
Il giorno dom, 02-01-2005 alle 23:26 +0100, Jaap Haitsma ha scritto:


* The CD burner menuitem does not have an icon and the window just has a folder icon.
* The computer window has a folder icon.
* Trash menuitem has no icon
After attached patch is applied:
* They have an appropriate icon
Especially the window icons are a big help finding back the burn or the computer window.

Only weird thing is that the trash icon looks a bit funny in the menu. The trash can (at least with the default gnome icons) seems a bit to slim, when you compare it with the icon on the desktop. It looks like that not both axes are scaled with the same amount (the other attachment shows this). It is I guess also caused by the fact that the 48x48 trash icon is actually 58x44 (Anybody knows why???)

I think that the wrong scaling is not caused by my patch or nautilus but
somewhere in GTK, where the gtkactionentries are assigned to the menus.

Heemm.. see
gtk_icon_theme_lookup_icon (icon_theme, icons_to_register[i], 48, 0);


gtk_icon_theme_load_icon (icon_theme, "gnome-dev-cdrom", 48, 0, NULL);

This ('48') means nautilus will pick up 48x48 pixmaps, then scale it
down to (usually) 16x16. This is bad, in a themeable desktop.

Good point. This is the way it was already done in Nautilus so I just extended it.

The blue sky scenario is 'declare' the name of the icon to use for each
items, then pick up the proper size (GTK_ICON_SIZE_MENU,
GTK_ICON_SIZE_LARGE_TOOLBAR ...) when appropriate.

Maybe a seperate patch correcting all these issues is the best option.

Maybe the gtk_image_* functions in GTK+ 2.6 could be useful.



Missing icon for Templates entry. A valid image is stock_new-template

I tried it but it looks really ugly.

See also discussion


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]