Re: [PATCH] Show icons for trash, cd burner and computer

[Alexander Larsson <alexl redhat com>]

On Tue, 2005-01-04 at 11:59 +0100, Jaap Haitsma wrote:
> Luca Ferretti wrote:
> > Il giorno dom, 02-01-2005 alle 23:26 +0100, Jaap Haitsma ha scritto:
> > 
> >>Hi,
> >>
> >>
> >>Now:
> >>* The CD burner menuitem does not have an icon and the window just has a 
> >>  folder icon.
> >>* The computer window has a folder icon.
> >>* Trash menuitem has no icon
> >>After attached patch is applied:
> >>* They have an appropriate icon
> >>Especially the window icons are a big help finding back the burn or the 
> >>computer window.
> >>
> >>Only weird thing is that the trash icon looks a bit funny in the menu. 
> >>The trash can (at least with the default gnome icons) seems a bit to 
> >>slim, when you compare it with the icon on the desktop. It looks like 
> >>that not both axes are scaled with the same amount (the other attachment 
> >>shows this). It is I guess also caused by the fact that the 48x48 trash 
> >>icon is actually 58x44 (Anybody knows why???)
> >>
> >>I think that the wrong scaling is not caused by my patch or nautilus but
> >>somewhere in GTK, where the gtkactionentries are assigned to the menus.
> > 
> > 
> > Heemm.. see 
> > 
> > gtk_icon_theme_lookup_icon (icon_theme, icons_to_register[i], 48, 0);
> > 
> > and
> > 
> > gtk_icon_theme_load_icon (icon_theme, "gnome-dev-cdrom", 48, 0, NULL);
> > 
> > This ('48') means nautilus will pick up 48x48 pixmaps, then scale it
> > down to (usually) 16x16. This is bad, in a themeable desktop.
> 
> Good point. This is the way it was already done in Nautilus so I just 
> extended it.

This is old code, from before gtk+ supported the icon theme spec. Maybe
now we don't have to do this anymore. Perhaps there is a better way.

> > The blue sky scenario is 'declare' the name of the icon to use for each
> > items, then pick up the proper size (GTK_ICON_SIZE_MENU,
> > GTK_ICON_SIZE_LARGE_TOOLBAR ...) when appropriate.
> 
> Maybe a seperate patch correcting all these issues is the best option.

Yeah, lets start by extending the current code.

> > Maybe the gtk_image_* functions in GTK+ 2.6 could be useful.
> > 
> > -----------
> > 
> > Issue#2
> > 
> > Missing icon for Templates entry. A valid image is stock_new-template
> > 
> I tried it but it looks really ugly.
> 
> See also discussion http://bugzilla.gnome.org/show_bug.cgi?id=162750

Lots of discussion there.

Also, the nautilus-window.c changes seem wrong to me, the special casing
of the location should be in nautilus_icon_factory_get_icon_for_file().

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an obese dishevelled stage actor in a wheelchair. She's a tortured 
insomniac politician with someone else's memories. They fight crime!