Re: nautilus crashes on upgrade fc2->fc3 in gnome 2.8

[Martin Wehner <martin wehner epost de>]

On Fri, 2004-12-03 at 16:59 +0100, Alexander Larsson wrote:
> On Fri, 2004-12-03 at 16:18 +0100, Alexander Larsson wrote:
> > The thing is, the name is used for metadata storage, such as the
> > positions of the icon on the desktop, emblems and whatnot. Using the
> > disk name instead of the volume name means the position of e.g. the
> > cdrom icon is always the same, even if you switch cds in the drive.
> > 
> > I'm not sure whats the best thing to do here. Just try to uniquify the
> > name if we already have a desktop icon with that name?
> 
> What about something like this (untested)? (I didn't get it to reproduce
> atm.)

Something like this should work, but this particular patch still
produces the same crash. nautilus_desktop_link_new_from_volume() doesn't
even return to create_volume_link() but crashes via create_icon_file()
in nautilus_desktop_icon_file_new() (the file is added to the directory
there). Attached are the juicy bits of the stack produced with this
patch applied.

Martin

Backtrace was generated from '/opt/gnome-2.8/bin/nautilus'

Using host libthread_db library "/lib/tls/libthread_db.so.1".
0x00b327a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
#0  0x00b327a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
#1  0x00d953fb in __waitpid_nocancel () from /lib/tls/libpthread.so.0
#2  0xf6d85a46 in libgnomeui_segv_handle (signum=6) at gnome-ui-init.c:741
#3  <signal handler called>
#4  0x00b327a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
#5  0x00b72955 in raise () from /lib/tls/libc.so.6
#6  0x00b74319 in abort () from /lib/tls/libc.so.6
#7  0xf663011c in g_logv (log_domain=0x0, log_level=13033460, 
    format=0xf6f92908 "file %s: line %d (%s): assertion failed: (%s)", 
    args1=0xfefa070c "��02") at gmessages.c:490
#8  0xf663013f in g_log (log_domain=0x0, log_level=G_LOG_LEVEL_ERROR, 
    format=0xf6f92908 "file %s: line %d (%s): assertion failed: (%s)")
    at gmessages.c:509
#9  0xf6f48827 in add_to_hash_table (directory=0x83bfc88, file=0x85d1cf8, 
    node=0x8578e4c) at nautilus-directory.c:552
#10 0xf6f4896a in nautilus_directory_add_file (directory=0x83bfc88, 
    file=0x85d1cf8) at nautilus-directory.c:590
#11 0xf6f3e081 in nautilus_desktop_icon_file_new (link=0x85f2590)
    at nautilus-desktop-icon-file.c:306
#12 0xf6f3e265 in create_icon_file (link=0x0) at nautilus-desktop-link.c:75
#13 0xf6f3e571 in nautilus_desktop_link_new_from_volume (volume=0x846f1c8)
    at nautilus-desktop-link.c:225
#14 0xf6f3ef1b in create_volume_link (monitor=0x83bec20, volume=0x846f1c8)
    at nautilus-desktop-link-monitor.c:150
#15 0xf66a45a9 in g_cclosure_marshal_VOID__OBJECT (closure=0x83c4018, 
    return_value=0x0, n_param_values=2, param_values=0xfefa0b80, 
    invocation_hint=0xfefa0a68, marshal_data=0x0) at gmarshal.c:636
#16 0xf668dfd1 in g_closure_invoke (closure=0x83c4018, return_value=0x0, 
    n_param_values=2, param_values=0xfefa0b80, invocation_hint=0xfefa0a68)
    at gclosure.c:437
#17 0xf66a1642 in signal_emit_unlocked_R (node=0x83aafe8, detail=0, 
    instance=0x83bc968, emission_return=0x0, instance_and_params=0xfefa0b80)
    at gsignal.c:2435
#18 0xf66a34d1 in g_signal_emit_valist (instance=0x83bc968, signal_id=1, 
    detail=0, 
    var_args=0xfefa0d10 " \016�216��216�\bh�\bX\r�213�\b�F\bX\r�63\213�at gsignal.c:2194
#19 0xf66a3713 in g_signal_emit (instance=0x83bc968, signal_id=26, detail=0)
    at gsignal.c:2238
#20 0xf68d2866 in _gnome_vfs_volume_monitor_mounted (
    volume_monitor=0x83bc968, volume=0x846f1c8)
    at gnome-vfs-volume-monitor.c:587
#21 0xf68b33af in gnome_vfs_client_volume_mounted (_servant=0x83aea7c, 
    corba_volume=0x86944cc, ev=0xfefa0f70) at gnome-vfs-client.c:81
#22 0xf68a6804 in _ORBIT_skel_small_GNOME_VFS_Client_VolumeMounted (
    _o_servant=0x83aea7c, _o_retval=0x0, _o_args=0x0, _o_ctx=0xfefa0ea0, 
    _o_ev=0xfefa0f70, 
    _impl_VolumeMounted=0xf68b337c <gnome_vfs_client_volume_mounted>)
    at GNOME_VFS_Daemon-common.c:73
#23 0xf66ea178 in ORBit_POAObject_invoke (pobj=0x0, ret=0x0, args=0xfefa0e20, 
    ctx=0xfefa0ea0, data=0x6, ev=0xfefa0f70) at poa.c:1141
#24 0xf66ee1ff in ORBit_OAObject_invoke (adaptor_obj=0x0, ret=0x0, 
    args=0xfefa0e20, ctx=0xfefa0ea0, data=0xfefa0f20, ev=0xfefa0f70)
    at orbit-adaptor.c:284
#25 0xf66dc7ae in ORBit_small_invoke_adaptor (adaptor_obj=0x83aead0, 
    recv_buffer=0xf56006b0, m_data=0xf68e8ac0, data=0xfefa0f20, ev=0xfefa0f70)
    at orbit-small.c:835
#26 0xf66ea4f6 in ORBit_POAObject_handle_request (pobj=0x83aead0, 
    opname=0xf5600874 "VolumeMounted", ret=0x0, args=0x0, ctx=0x0, 
    recv_buffer=0xf56006b0, ev=0xfefa0f70) at poa.c:1350
#27 0xf66ea9f5 in ORBit_POAObject_invoke_incoming_request (pobj=0x83aead0, 
    recv_buffer=0xf56006b0, opt_ev=0x0) at poa.c:1418
#28 0xf66eaaee in poa_invoke_at_idle (data=0xf5600538) at poa.c:1466
#29 0xf662b420 in g_idle_dispatch (source=0xf5600720, callback=0, 
    user_data=0xf5600538) at gmain.c:3816
#30 0xf66282ec in g_main_context_dispatch (context=0x832f5a0) at gmain.c:1942
#31 0xf6629d19 in g_main_context_iterate (context=0x832f5a0, block=1, 
    dispatch=1, self=0x830f380) at gmain.c:2573
#32 0xf6629f98 in g_main_loop_run (loop=0x83c4380) at gmain.c:2777
#33 0xf6aad6df in gtk_main () at gtkmain.c:1173
#34 0x08074db4 in main (argc=4, argv=0xfefa12f4) at nautilus-main.c:332