Re: nautilus crashes on upgrade fc2->fc3 in gnome 2.8

[Alexander Larsson <alexl redhat com>]

On Tue, 2004-11-30 at 21:20 +0100, Martin Wehner wrote:
> On Mon, 2004-11-22 at 23:21 +0100, Martin Wehner wrote:
> > On Mon, 2004-11-22 at 22:40 +0100, Martin Wehner wrote:
> > > /* We try to use the drive name to get somewhat stable filenames
> > >    for metadata */
> > > drive = gnome_vfs_volume_get_drive (volume);
> > > if (drive != NULL) {
> > > 	name = gnome_vfs_drive_get_display_name (drive);
> > > } else {
> > > 	name = gnome_vfs_volume_get_display_name (volume);
> > > }
> > > gnome_vfs_drive_unref (drive);
> > > link->details->filename = g_strconcat (name, ".volume", NULL);
> > 
> > It looks like it wouldn't work for two volumes on the same drive
> > either.. What does using the disk name buy you here?
> 
> Alex,
> 
> could you have a look at this? With 24 duplicates, it's the undisputed
> top crasher of the 2.8.x series.
> I'd say let's remove the usage of the drive name altogether, because
> you'd have to jump through hoops to guarantee the uniqueness of the
> desktop link filename at this point.
> What do you think?

The thing is, the name is used for metadata storage, such as the
positions of the icon on the desktop, emblems and whatnot. Using the
disk name instead of the volume name means the position of e.g. the
cdrom icon is always the same, even if you switch cds in the drive.

I'm not sure whats the best thing to do here. Just try to uniquify the
name if we already have a desktop icon with that name?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a hate-fuelled ninja werewolf searching for his wife's true killer. She's 
a manipulative hypochondriac advertising executive on her way to prison for a 
murder she didn't commit. They fight crime!