canonicalization change broke eel check



The following change (i think) broke make distcheck in eel:
2002-07-15  Frederic Crozat  <fcrozat mandrakesoft com>

	* libgnomevfs/gnome-vfs-uri.c: (set_uri_element):
	canonize NULL uri into "/". "start-here:" will now be
	canonized into "start-here:///", fixing some monitoring
	problem in nautilus


make distcheck in eel breaks in the self-tests like this:

running eel_self_check_vfs_extensions

FAIL: check failed in eel-vfs-extensions.c, line 1870
      evaluated: eel_make_uri_canonical ("file:")
       expected: file:
            got: file:///
FAIL: check failed in eel-vfs-extensions.c, line 1872
      evaluated: eel_make_uri_canonical ("glorp:")
       expected: glorp:
            got: glorp:///
FAIL: check failed in eel-vfs-extensions.c, line 1928
      evaluated: eel_format_uri_for_display (":")
       expected: :
            got: :///

eel_make_uri_canonical() that uses gnome_vfs_make_uri_canonical() is used 
a lot. Are we sure this behavorial change is correct everywhere? Nautilus 
may rely on the old behaviour somewhere.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a witless arachnophobic boxer looking for 'the Big One.' She's a 
beautiful cat-loving Hell's Angel with the power to bend men's minds. They 
fight crime! 





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]