Re: [Nautilus-list] some eel patching

[Darin Adler <darin bentspoon com>]

on 10/31/01 8:35 PM, Havoc Pennington at hp redhat com wrote:

> I went to town on eel-gtk-extensions.c, and got a couple other things
> too.

Please commit. I do have some questions though.

> +    * eel/eel-gtk-extensions.c (eel_gtk_window_present): that one was
> +    easy

Does gtk_window_present handle both workspace and area? If it does, then I
want to just remove eel_gtk_window_present. The only reason I didn't do this
before is that I thought that the eel one still did a bit more than the GTK
one.

> +    (eel_get_current_event_time): simplify using GTK 2 features

I'll remove this and change clients to use gtk directly.

> +    (eel_drag_set_icon_pixbuf): simplify using GTK 2 features

I'll remove this and change clients to use gtk directly.

> +    (eel_gtk_pixmap_new_empty): make this less lame

Probably will be removed soon.

> +    (eel_gtk_widget_set_font): simplify using GTK 2 features

I'll remove this and change clients to use gtk directly.

> +    (eel_gtk_style_set_font): delete, this was totally broken; I don't
> +    know what it's for but we have to do it a different way

Good. I was going to suggest that.

> +    (EEL_STANDARD_BUTTON_PADDING): remove, should fix in GTK if we are
> +    going to fix it
> +    (eel_gtk_button_set_standard_padding): make a no-op, should fix in
> +    GTK

This change seems just plain wrong to me. If we don't need the call, we
should remove it. But I'm not happy with making that decision without
looking at why and where the call was used before.

I agree with the sentiment that this should go, but just neutering it at the
eel level seems wrong to me. Lets remove it from the places it's used, then
delete it.

> +    (eel_gtk_button_auto_click): make it do nothing, GTK does this for
> +    you now

Should be removed rather than neutered. An doesn't it need to do
gtk_widget_activate rather than nothing, if we're trying to neuter it?

> +    (eel_gtk_window_set_up_close_accelerator): make it whine if you
> +    use it on GtkDialog, since that breaks the standard GtkDialog
> +    close accelerators

Would you be willing to explain this a bit more?

    -- Darin