[Nautilus-list] [Fwd: About wchar support.]




-------- Original Message --------
Subject: About wchar support.
Date: Thu, 14 Jun 2001 12:01:36 +0000
From: James Su <suzhe gnuchina org>
To: Darin Adler <darin bentspoon com>
References: <200106131846 f5DIkK522602 mx eazel com>



Hello,
I found that nautilus and eel treat almost all string as char *, it's not an i18n compatible method. May be it's better to use wchar_t * (GdkWChar *) instead of char * (gchar*) as internal string type. It would simplify the string handle and will achieve better i18n compatiblity.

Regards,

James Su

Darin Adler wrote:

On Wednesday, June 13, 2001, at 06:47  AM,  wrote:

   I made two patches for Eel library 1.0 to deal with multibyte string
ellipsize and smooth text layout bugs.
   I have test these patch under zh_CN.GB2312 and zh_CN.GBK locales.


These patches look pretty good. One small problem with them is that they don't use the proper coding style. For example, you write:

    g_free( xxx );

and in Eel, the style is:

    g_free (xxx);

and you write:

    if( wc_text_len <= 0 ){

but in Eel, the style is:

    if (wc_text_len <= 0) {

If you would fix these minor problems and resubmit the patch it would be much appreciated.

    -- Darin

_______________________________________________
Nautilus-list mailing list
Nautilus-list lists eazel com
http://lists.eazel.com/mailman/listinfo/nautilus-list








[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]