[Nautilus-list] nautilus-text-view and services

[Benedikt Roth <Benedikt Roth gmx net>]

Hi!

While looking at the nautilus-text-view code to fix bug #6546 ("Cut", "Copy,
"Paste" and "Clear" permanently enabled while using Text View)
I found something I did not notice before: The services for the text view
which enables one to look up selected text with Google or in the Webster
dictionary.
I think they are quite usefull and I would like to keep them around (or even
add a few more) but they won't get displayed because the 'Services' menu 
has been removed.
The attached patch removes the references to services.eazel.com in the 
services xml files and moves the menu items to the 'Edit' submenu.
This is nice for the moment but may not be the best solution and we should 
discuss if this is the right thing to do...

Regards,

	Benedikt

P.S.: I'd like to hack a bit on the text view and would also like to know
what's the status of my 'select all, unselect all and invert selection
patch' I sent to the list some time ago...

? nautilus-text-services.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/nautilus/ChangeLog,v
retrieving revision 1.4668
diff -u -r1.4668 ChangeLog
--- ChangeLog	2001/07/02 15:55:01	1.4668
+++ ChangeLog	2001/07/02 18:52:10
@@ -1,3 +1,11 @@
+2001-07-02  Benedikt Roth  <Benedikt Roth gmx net>
+
+	* components/text/nautilus-text-view.c
+	  Moved the service items to the 'Edit' submenu
+	* components/text/services/google.xml
+	* components/text/services/webster.xml: 
+	  Removed references to http://services.eazel.com
+
 2001-07-02  Cody Russell  <bratsche gnome org>
 
 	* libnautilus-private/nautilus-volume-monitor.[ch]: Added
Index: components/text/nautilus-text-view.c
===================================================================
RCS file: /cvs/gnome/nautilus/components/text/nautilus-text-view.c,v
retrieving revision 1.28
diff -u -r1.28 nautilus-text-view.c
--- components/text/nautilus-text-view.c	2001/05/04 10:19:25	1.28
+++ components/text/nautilus-text-view.c	2001/07/02 18:55:55
@@ -59,7 +59,7 @@
 #define MAX_FILE_SIZE	1024*1024
 #define MAX_SELECTION_SIZE 256
 
-#define ADDITIONAL_SERVICES_MENU_PATH	"/menu/Services Placeholder/Services/Service Items"
+#define ADDITIONAL_SERVICES_MENU_PATH	"/menu/Edit"
 
 #define NAUTILUS_PREFERENCES_TEXT_VIEW_FONT                     "components/text_view/font"
 #define NAUTILUS_PREFERENCES_TEXT_VIEW_STANDARD_FONT_SIZE       "components/text_view/standard_font_size"
Index: components/text/services/google.xml
===================================================================
RCS file: /cvs/gnome/nautilus/components/text/services/google.xml,v
retrieving revision 1.4
diff -u -r1.4 google.xml
--- components/text/services/google.xml	2001/02/23 03:04:10	1.4
+++ components/text/services/google.xml	2001/07/02 18:55:55
@@ -1,3 +1,3 @@
 <?xml version="1.0"?>
 <service _label="Search Google for Selected Text" source="selection"
-  template="http://services.eazel.com/redirect?http://www.google.com/search?q=%s"; _tooltip="Use Google to search the web for the selected text"/>
+  template="http://www.google.com/search?q=%s"; _tooltip="Use Google to search the web for the selected text"/>
Index: components/text/services/webster.xml
===================================================================
RCS file: /cvs/gnome/nautilus/components/text/services/webster.xml,v
retrieving revision 1.4
diff -u -r1.4 webster.xml
--- components/text/services/webster.xml	2001/02/23 03:04:10	1.4
+++ components/text/services/webster.xml	2001/07/02 18:55:55
@@ -1,3 +1,3 @@
 <?xml version="1.0"?>
 <service _label="Look Up Selected Text in Dictionary" source="selection"
-  template="http://services.eazel.com/redirect?http://www.m-w.com/cgi-bin/dictionary?va=%s"; _tooltip="Look up the selected text in the Merriam-Webster dictionary"/>
+  template="http://www.m-w.com/cgi-bin/dictionary?va=%s"; _tooltip="Look up the selected text in the Merriam-Webster dictionary"/>