Fwd: [Muine] [PATCH] C# implementations of MessageConnection and VolumeButton



Jorn,

(sorry that you're getting this twice, accidentally didn't send it to
the list the first time)

I've attached a patch which fixes the problem that you described. Now
the client simply sends its entire arg array to the server and the
server processes it exactly as it would process command line args
originally passed to it. I'm still not sure why the server wasn't fast
enought to respond in the first place. Do you have any ideas? Either
way, this leads to a cleaner implementation.

I also noticed that a callback given to GLib.Idle.Add () in
SongDatabase.cs was getting GC'd while the idle loop was still using
it. I would think that GLib would handle this for us, but I guess not.
I've made the callback a private field to avoid the issue.

Cheers,
Ross

On Fri, 1 Oct 2004 08:47:28 -0400, Ross Girshick


<ross girshick gmail com> wrote:
> I'm not sure if I'll have time to fix it this weekend due to work, but
> I'll try to get around to it.
>
> Ross
>
>
>
>
> On Fri, 01 Oct 2004 14:36:28 +0300, Jorn Baayen <jbaayen gnome org> wrote:
> > Hi,
> >
> > There is a bug in your message connection impl: The server isn't
> > receiving multiple commands sent quickly after each other. For example,
> > try, when you have one instance running already, "muine a.mp3 b.mp3".
> > Only a.mp3 gets added.
> >
> >
> >
> > Cheers,
> >
> > Jorn

Attachment: messageconnection.patch
Description: Binary data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]