Re: [Muine] [PATCH] checked_cover_image weirdness?

[Jorn Baayen <jorn nl linux org>]

Hi,

Thanks for nailing this one!

It isn't exactly the right fix though, we need that check for when we
add support for manually setting the cover image. The bug of it getting
set to true was somewhere else. I commited to fix to CVS, but I'm
attaching a patch too so that you can test it without having to wait for
the cvs resync.

Cheers,

Jorn

On Wed, 2004-01-28 at 02:18, Samuel Ziegler wrote:
> I was experiencing an issue wherein after FetchAlbumCover, and Proxy is
> called, checked_cover_image is always true.  Even when a new album cover
> had been found.  The first few lines of Proxy checks the value of
> checked_cover_image and bail if it is not found.  From looking at the
> code, I wasn't sure why this check existed.  Since I couldn't seem to
> find a good reason, I removed the check.  Now everything seems to work
> fine.
> 
> Comments?
>   - Sam

Index: src/Song.cs
===================================================================
RCS file: /cvs/gnome/muine/src/Song.cs,v
retrieving revision 1.16
diff -u -r1.16 Song.cs
--- src/Song.cs	27 Jan 2004 19:25:42 -0000	1.16
+++ src/Song.cs	28 Jan 2004 13:30:13 -0000
@@ -93,7 +93,8 @@
 		set {
 			cover_image = value;
 
-			checked_cover_image = true;
+			if (cover_image != null)
+				checked_cover_image = true;
 		}
 		
 		get {