Re: Version control support call for help

[Louis des Landes <louis obsidian com au>]

Having a browse through at the moment.

Some quick questions:

* get_commit_message_prefill - you use a file (.git/MERGE_MSG) which only exists when git has just done a merge? Bazaar doesn't have an equivalent here, although I guess we could check if there's a pending merge and put some text in manually, but I feel this is the wrong choice.

* Should the various commit/diff/update/add/remove/revert methods use the existing <method>_command (diff_command etc) methods? There seems to be some duplication here, but I'm guessing it's a WIP.

* A few methods (get_commits_to_push_summary for eg) aren't prototyped yet and only exist in git... guessing also a WIP? I can't quite figure out what this method is being used for (only referenced in the _set_location method in vcview at the moment)

Happy to take this conversation off list if it's more convenient (github comments perhaps?)

Louis.

--
Louis

On 25 May 2013 06:06, Kai Willadsen <kai willadsen gmail com> wrote:

On 22 May 2013 14:31, Louis des Landes <louis obsidian com au> wrote:
> I'm happy to stick up a hand for bazaar - my workplace uses it heavily, and
> I'm quite a fan of it.

That would be fantastic, cheers.

> Right now it's in a good state, and I use the 3-way merge on conflict
> functionality regularly (navigating my work's VC trees can be spiderwebby
> sometimes :\ )
> I did just poke my head in to bugzilla and there's nothing specifically
> referencing bazaar itself - is there anything in particular outstanding?

You're right, as far as I know Bazaar is in a pretty good state right now.

Currently this is mostly about new functionality and fixes. In
what-will-be 1.7.3, Git has:
 * added support for a Push command;
 * fixed Pull so that it works regardless of the currently selected file;
 * gained support for some auto-generated commit messages;
 * added a listing of files that will be committed in the commit dialog; and
 * added support for correctly setting action sensitivity based on
current selection.

All of this has involved new API in VC modules, and no other VC
implements any of it right now. Some of it won't be applicable to
other VCs (i.e., the Pull thing was a Git-specific problem, but it may
also be a problem elsewhere). Bazaar should keep working as it does
now, but implementing some of this would improve that experience.

Like I said, some of this will involve bugging me about adding,
adapting and documenting new API, and that's cool. You should do so!

cheers,
Kai