Re: [PATCH] Fix execution of when executing via "python -m xxx meld"



On 16 April 2012 08:10, Peter Tyser <ptyser gmail com> wrote:
> On Sat, Apr 14, 2012 at 3:11 PM, Kai Willadsen <kai willadsen gmail com> wrote:
>> I'm not a fan of the argv[0] thing to be honest. Using __file__ feels
>> like the Right Way to do it, and absent evidence to the contrary I'd
>> like to stick to it. I might be open to adding a runpy-specific
>> workaround, but given that this is only a problem for some modules and
>> it doesn't even seem to be a problem from 2.7 on, I'm not convinced
>> that it's worth it.
>
> OK.  I don't think its too big of a deal either, especially since it
> only affect developers with older software installed.  Potentially a
> check of "if os.path.basename(__file__) != "meld" could be added with
> an error message, or fallback to using argv[0].  In any case, feel
> free to ignore this patch, or let me know if you want some
> check/workaround added and I'll respin.

I decided that your suggestion of using sys.argv[0] as a fall-back was
a good idea, and didn't have any other serious impact, so I went ahead
and added it.

> I like the new website for what its worth!

Thanks! I won't claim to be a designer or anything, but at least it's
a bit of a refresh.

cheers,
Kai


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]