Re: [PATCH] handling of KeyboardIterrupt added

[Sylvain Rabot <sylvain abstraction fr>]

On Sat, May 8, 2010 at 02:09, Kai Willadsen <kai willadsen gmail com> wrote:
> On 7 May 2010 20:45, Sylvain Rabot <sylvain abstraction fr> wrote:
>> On Mon, May 3, 2010 at 03:31, Kai Willadsen <kai willadsen gmail com> wrote:
>>> On 28 April 2010 06:41, Sylvain Rabot <sylvain abstraction fr> wrote:
>>>> When meld is launched in a shell and you kill it with ^C signal
>>>> there is some python error output which can be avoid with this patch.
>>>
>>> I'm not sure I really see the benefit of doing this. We don't do a lot
>>> of stuff that needs cleanup, but killing Meld like that is a great way
>>> to lose work.
>>
>> Well, in that case KeyboardInterrupt exceptions should be caught and
>> emit a warning when there is unsaved changes in meld
>
> I just tested four different applications (gedit, gimp, reinteract,
> and abiword) and none of them try to catch and deal with Ctrl+C in
> this way.
>
>> otherwise the
>> program should be terminated without python error output.
>
> I still don't see why you expect to see no traceback. You pressed
> Ctrl+C; a traceback is expected behaviour.

And I don't see why it's expected to have an error traceback telling
me I have pressed Ctrl+C.
I can understand having a message telling something like "meld
terminated by user ..." but a python traceback is really aggressive
and really not useful.

>
> Kai
>


-- 
Sylvain