Re: Patch for new feature, show whitespace

[Kai Willadsen <kai willadsen gmail com>]

On 22 June 2010 00:19, Vincent Legoll <vincent legoll gmail com> wrote:
> On Sun, Jun 20, 2010 at 6:12 PM, Jon Dufresne <jon dufresne gmail com> wrote:
>> I created a patch to allow the user to show whitespace in diff. I
>> prefer to look at my diffs this way. I have exposed this feature
>> through the preferences the same what the show line numbers is done.
>>
>> Let me know what you think.
>
> That look ok from the very quick look I had.
> Do you know if it would be difficult to show (boldly, red color or something
> like in vim) only whitespace at end of line ?
>
> That one would certainly interrest a lot of people...

I think this would be bug #589366:
https://bugzilla.gnome.org/show_bug.cgi?id=589366

However, as I said there, I think we want to highlight *changes* in
trailing (and probably leading) whitespace, not just the trailing
whitespace. No one wants their entire file lighting up because the
whitespace was already there, but you *do* want to avoid committing
new trailing whitespace yourself.

cheers,
Kai