Re: [PATCH] Avoid bzr aliases and plugins
- From: Rainer Müller <raimue codingfarm de>
- To: meld-list gnome org
- Subject: Re: [PATCH] Avoid bzr aliases and plugins
- Date: Tue, 21 Jul 2009 15:21:01 +0200
On 2009-07-20 22:42 , Stephen Kennedy wrote:
>>> The options --no-aliases and --no-plugins avoid problems when a user
>>> defined custom aliases for commands or installed plugins changing the
>>> output or behavior.
>>
>> Looks like --no-plugins appeared in 0.90 (31-Aug-2007) and --no-alias
>> was already there in 0.8 (29-Aug-2006)
>>
>> This patch looks OK, any reason Rainer or I should not commit them ?
>
> Looks good. How about making self.CMD a list and moving the args there
> instead of repeating them?
Probably a good idea. I just wanted to be least intrusive and as all
other VC plugins also have CMD set as a string I didn't want to change that.
I will send another patch which specifies these arguments at a single place.
Rainer
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]