Re: [PATCH] Avoid bzr aliases and plugins

From: Stephen Kennedy <stevek gnome org>
To: Vincent Legoll <vincent legoll gmail com>
Cc: meld-list gnome org
Subject: Re: [PATCH] Avoid bzr aliases and plugins
Date: Mon, 20 Jul 2009 21:42:34 +0100

>> The options --no-aliases and --no-plugins avoid problems when a user
>> defined custom aliases for commands or installed plugins changing the
>> output or behavior.
>
> Looks like --no-plugins appeared in 0.90 (31-Aug-2007) and --no-alias
> was already there in 0.8 (29-Aug-2006)
>
> This patch looks OK, any reason Rainer or I should not commit them ?

Looks good. How about making self.CMD a list and moving the args there
instead of repeating them?

Stephen.

Follow-Ups:
- Re: [PATCH] Avoid bzr aliases and plugins
  - From: =?UTF-8?B?UmFpbmVyIE3DvGxsZXI=?=

References:
- [PATCH] Avoid bzr aliases and plugins
  - From: Rainer Mueller
- Re: [PATCH] Avoid bzr aliases and plugins
  - From: Vincent Legoll

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]