Re: Windows support

[Vincent Legoll <vincent legoll gmail com>]

On Wed, Apr 22, 2009 at 9:48 AM, Vincent Legoll
<vincent legoll gmail com> wrote:
> On Wed, Apr 22, 2009 at 8:24 AM, Lorenz <lorenznl yahoo com> wrote:
>>>did you try to change the Path modification to become:
>>>
>>>6. Add this to your Path:
>>>    * C:\dev\Python26;C:\dev\gtk+\bin;C:\dev\gladewin32\bin;C:\dev\cygwin\bin
>>
>> yes (of course 8-) and with this change meld starts without errors.
>
> Thanks, the wiki is updated
>
>> Help/F1 does not work though. Any Ideas?
>
> No, but I'll have a look at it.

You don't have gnome libs available nor a recent enough pygtk version...
Is the attached patch user-friendlier than silent failure ?

-- 
Vincent Legoll

diff --git a/meldapp.py b/meldapp.py
index 55c63f0..8ef1950 100644
--- a/meldapp.py
+++ b/meldapp.py
@@ -769,7 +769,10 @@ class MeldApp(gnomeglade.Component):
     # Toolbar and menu items (help)
     #
     def on_menu_help_activate(self, button):
-        misc.open_uri("ghelp:///"+os.path.abspath(paths.help_dir("C/meld.xml")))
+        ret = misc.open_uri("ghelp:///" + os.path.abspath(paths.help_dir("C/meld.xml")))
+        if not ret:
+            misc.run_dialog(_("Cannot show help, as you don't have a recent enough pygtk version nor the python gnome libraries installed."),
+                            parent=self, buttonstype=gtk.BUTTONS_OK)
 
     def on_menu_help_bug_activate(self, button):
         misc.open_uri("http://bugzilla.gnome.org/buglist.cgi?query=product%3Ameld";)
diff --git a/misc.py b/misc.py
index 91f5ea5..1b0855d 100644
--- a/misc.py
+++ b/misc.py
@@ -88,7 +88,8 @@ def open_uri(uri, timestamp=0):
             import gnome
             gnome.url_show(uri)
         except ImportError:
-            pass
+            return False
+    return True
 
 # Taken from epiphany
 def position_menu_under_widget(menu, widget):