Re: [PATCH] CVS ${HOME} should be an absolute path

On Fri, Apr 3, 2009 at 9:09 AM, Stephen Kennedy <stevek gnome org> wrote:
> On Sat, Mar 28, 2009 at 1:49 AM, Vincent Legoll
> <vincent legoll gmail com> wrote:
>> Was that a cut'n'paste mistake, or was it really intended
>> to os.path.join directory with ${HOME} here. I don't
>> understand how it could make sense. Please explain.
> Yes, the original code is confusing. Strangely it works ok though
> because of the strange behavior of os.path.join! os.path.join("foo",
> "/bar") == "/bar"

Yes that's what I found, but we shouldn't rely on corner cases, let our
code be straight clean and easily understandable.

Vincent Legoll

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]