Re: [PATCH] Construct VC directory filter for supported plugins

On Fri, Apr 3, 2009 at 9:27 AM, Stephen Kennedy <stevek gnome org> wrote:
> 2009/3/30 Vincent Legoll <vincent legoll gmail com>:
>> here is a first shot at replacing the hard-coded
>> directory filter for VC metadata directories.
>> I'd really appreciate comments about how to
>> implement a better (complete ?) shell_escape()
>> in The current one is working for now
>> but is not OK for a long term solution.
> Looks good. Maybe just punt for now and assert
> on the unhandled cases? In this case it might be
> better to keep the "incomplete" function local in

I'm really not sure we want to put an unrelated
function like that in, it is the complementary
to shell_to_regex(), so I think it should be near, even if
not completely implemented.

I'll add the required assertions though

Vincent Legoll

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]