Re: problems with man2hlp

["Andrew V. Samoilov" <sav bcs zp ua>]

Brad Cowan wrote:
> ----- Original Message -----
> From: Pavel Roskin <proski gnu org>
> Date: Wed, 13 Nov 2002 03:01:29 -0500 (EST)
> To: Brad Cowan <bcowan gentoo org>
> Subject: Re: problems with man2hlp
>
>
>
> > Hello!
> >
> >
> > >         I am a developer working with Gentoo Linux, and we been having
> > > problems compiling 4.6.0_pre1 snapshots. This problem arises with
> > > man2hlp, when trying to transform the man pages to help files this
> > > program will totally fill up the build partition/dir on various machines
> > > to which I have not been able to find a common link.  Any advice would
> > > be appreciated as the snapshots seem to fix alot of problems and are
> > > coming along nicely.
> >
> > I have never seen this bug.  Maybe my yesterday's fix helps:
> >
> > 2002-11-11  Pavel Roskin  <proski gnu org> 
> > ,,,
> >        * man2hlp.c: Warning fixes.  size_t can be unsigned.
> >
> > Try man2hlp.c from CVS, and if it's still broken, I'll have a closer look.
> > You can get it from LXR:
> >
> > http://cvs.gnome.org/lxr/source/mc/src/man2hlp.c?raw=1
> >
> > --
> > Regards,
> > Pavel Roskin
>
>
>
> After further testing, and doing what u suggested, the filling of entire partition is still happening.
>
> ../../src/man2hlp mc.1 ./xnc.hlp mc.hlp.es
>  
> This is where the compile does this on the boxes in question.

Can you test attached patch?


--
Regards,
Andrew V. Samoilov

--- man2hlp.c.ori       Tue Nov 12 09:39:40 2002
+++ man2hlp.c   Wed Nov 13 16:49:17 2002
@@ -780,6 +780,12 @@ main (int argc, char **argv)
     }
 
     cont_start = ftell (f_out);
+
+    if (cont_start == -1){
+       perror ("ftell fails");
+       return 1;
+    }
+
     if (topics)
        fprintf (f_out, "\004[Contents]\n%s\n\n", topics);
     else