Re: mc and me



On Sun, 2015-11-08 at 22:14 +0100, Egmont Koblinger wrote:

My git knowledge is pretty accurately described by
http://xkcd.com/1597/ , so the first time I'll do that branching and
merging (esp. the latter) it'd be great if someone double checked on
me.

Sure, I can try to find time to help... Are you on IRC? Otherwise, I've
just revealed a magic trick to attract my attention by email.

Some info is available from here:

http://www.midnight-commander.org/wiki/GitGuideLines

http://www.midnight-commander.org/wiki/WorkingGuideLines

http://www.midnight-commander.org/wiki/Hacking

Also: What are the steps to be performed before/after a commit?

You pretty much summed it up :-) Commit everything is a nice patch
series to a topic branch, check tests & indentation, create tentative
NEWS entry and push for review...

I mean, run the unittests (make tests -- that's it?),

Yes, that's always a good idea.

check if the code is formatted (make indent -- correct?), 

Yes; in addition, Travis is supposed to do it when you push your feature
branch, and inform by email if there is a problem.

update the NEWS file (how?), anything else?

When the ticket it closed, it should be added to the news page:

http://www.midnight-commander.org/wiki/NEWS-4.8.16

From there, it makes it into the release NEWS; see the old one here:

http://www.midnight-commander.org/wiki/NEWS-4.8.15

-- 
Sincerely yours,
Yury V. Zaytsev




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]