Re: [PATCH] Fix build on HP-UX 11.11

[Mikulas Patocka <mikulas artax karlin mff cuni cz>]

On Fri, 7 Dec 2012, Andrew Borodin wrote:

> On Fri, 7 Dec 2012 02:10:39 +0100 (CET) Mikulas Patocka wrote:
> > Fix build on HP-UX 11.11
> >
> > HP-UX 11.11 doesn't have strtoll, but it has strtoimax. strtoimax is
> > defined as a preprocessor macro, not as a function.
> >
> > This patch fixes build: it adds checks for two function strtoll and
> > strtoimax and uses them if detected.
> 
> Thanks for the patch! mc is being developed under Linux only, so patches to
> improve mc portability are welcome!
> 
> > BTW. in ./src/vfs/fish/fish.c and ./lib/vfs/parse_ls_vga.c there is a
> > detection for atoll and if atoll is not found, atof is used. Shouldn't
> > strtoll (or strtoimax) be used instead of atof?
> 
> I think, the better way is use g_ascii_strtoll, but it requires glib >= 2.12.
> Current minimal glib version required for mc is 2.8.

... or you can test for g_ascii_strtoll in autoconf.

Mikulas

> BTW, glib-2.12.0 was released on 16 Aug 2006, so I think, we can change minimal
> required glib version for mc up to 2.12 or even 2.15.
> 
> --
> Andrew