Re: [Midnight Commander] #2: savannah: UTF-8 locales not supported

[Vladimir Nadvornik <nadvornik suse cz>]

Hi all,

On po 5. ledna 2009, Ticket System wrote:
> #2: savannah: UTF-8 locales not supported
> -------------------------+-------------------------------------------------
>- Reporter:  slavazanko  |       Owner:  slavazanko
>       Type:  defect      |      Status:  accepted
>   Priority:  major       |   Milestone:  UTF8 Support
>  Component:  mc-core     |     Version:
> Resolution:              |    Keywords:
>   Blocking:              |   Blockedby:
> -------------------------+-------------------------------------------------
>- Changes (by slavazanko):
>
>   * owner:  => slavazanko
>   * status:  new => accepted
>   * milestone:  Recode Support => UTF8 Support
>
>
> Comment:
>
>  I propose this patches: http://www.fi.muni.cz/~xbenes5/projects/mc/mc-
>  utf8.tar.gz
>
>  Link from: http://mail.gnome.org/archives/mc-
>  devel/2007-December/msg00001.html
>
>  IMHO, this more right patches than patches from Fedora, Suse etc (no
>  stupid #ifdef..#else...#endif in many source files).
>

The ifdefs should not be the main criteria to judge the quality of patches. 
They are there to allow compilation without wchar.h. I think that they can be 
easily replaced by some wrapper functions if neccessary.

Here are other points:

The distributions patches:
- are much more tested and the most of places in the code that needs changes 
was already identified and fixed somehow
- the implementation uses utf-8 strings in mc itself and wchar_t strings in 
editor

Patches from http://www.fi.muni.cz/~xbenes5:
- do not include utf-8 support in editor at all
- there was not so much testing
- I didn't look at the implementation details

Vladimir