[Midnight Commander] #123: savannah: 2GB file size limit in fish

["Ticket System" <tickets midnight-commander org>]

#123: savannah: 2GB file size limit in fish
------------------------+---------------------------------------------------
 Reporter:  slavazanko  |       Owner:       
     Type:  defect      |      Status:  new  
 Priority:  major       |   Milestone:       
Component:  mc-core     |     Version:  4.6.1
 Keywords:              |    Blocking:       
Blockedby:              |  
------------------------+---------------------------------------------------
 Original: http://savannah.gnu.org/bugs/?15524

 ||Submitted by:||Ludovic Drolez <ldrolez>||Submitted on:||Tue 24 Jan 2006
 06:03:58 PM UTC||
 ||Category:||VFS||Severity:||3 - Normal||
 ||Status:||None||Privacy:||Public||
 ||Assigned to:||None||Open/Closed:||Open||
 ||Release:||All versions||Operating System:||All||

 Discussion:
 {{{
 Fri 27 Apr 2007 10:14:45 AM UTC, comment #2:

 This patch was over simplistic and should have been verified better
 before checking in. There were two problems with it:

 a) it used the 'L' length modifier which is supposed to be used
 with floating point data types as opposed to integers. Yes, glibc
 allows it but it is noted that such use should be considered a bug.

 b) it didn't care about the actual size of off_t

 I've checked in a patch which fixes both problems:

 http://cvs.sv.gnu.org/viewcvs/mc/mc/vfs/fish.c?sortby=date&r2=1.117&r1=1.116&diff_format=u
         Pavel Tsekov <ptsekov>
 Project Administrator
 Fri 27 Jan 2006 07:43:38 PM UTC, comment #1:

 A patch has just been submitted to the debian BTS.
         Anonymous
 Tue 24 Jan 2006 06:03:58 PM UTC, original submission:

 Hi,
 Someone reported the bug on the debian bts: http://bugs.debian.org/349390.

 After inspecting fish.c it seems that there are 31 bits limitations
 everywhere and in particular in:
 - fish_linear_start(): ... sscanf( reply_str, "%d", ...
 - &fh->u.fish.total : declared as an int

 Cheers,
 Ludo

 }}}

-- 
Ticket URL: <http://www.der-winnie.de/trac/ticket/123>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center