Re: [PATCH] segfault-on-invalid-mtime fix

[Enrico Weigelt <weigelt metux de>]

* Miguel de Icaza <miguel novell com> schrieb:

Hi,

>     This patch looks good, but there are two uses of strftime as well,
> it might make sense to wrap the use of strftime in a new routine that
> always make this check (when localtime returns NULL).

I'm working on that.

BTW: we've got some situations where precense of strftime() is
checked (HAVE_STRFTIME) and fallback to ctime(), and some where
it is NOT. 

Should we always do the #ifdef or completely drop the fallback ? 


cu
-- 
---------------------------------------------------------------------
 Enrico Weigelt    ==   metux IT service - http://www.metux.de/
---------------------------------------------------------------------
 Please visit the OpenSource QM Taskforce:
 	http://wiki.metux.de/public/OpenSource_QM_Taskforce
 Patches / Fixes for a lot dozens of packages in dozens of versions:
	http://patches.metux.de/
---------------------------------------------------------------------