Re: Fix for password-protected .rar files

Hello Denis,

On Mon, 24 Jul 2006, Denis Vlasenko wrote:

The patch includes random quoting of shell variables as well
as formatting fixes  - please submit a proper patch which does
only what it advertises.

Ok, the attached patch quotes some environment variables.

vfs/extfs/* scripts seem to presume that there are no spaces
in filenames. Yes, we typically do not expect $TMPDIR to contain spaces,
but if it will contain them on some strange system, then what?
Is cd $TMPDIR ok? No! cd "$TMPDIR"!

The attached patch fixes these.

The attached patch again includes indentation-only fixes (rpm, trpm, uar, maybe others). Please, submit a proper patch.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]