Re: Fix for password-protected .rar files



On Monday 24 July 2006 17:54, Andy Shevchenko wrote:
> Denis Vlasenko пишет:
> > -	$ISOINFO -i "$1" -x "/$2" > "$3" 
> > +    $ISOINFO -i "$1" -x "/$2" > "$3" 
> > -  RPM="rpm --nosignature"
> > +    RPM="rpm --nosignature"
> > -  RPM="rpm"
> > +    RPM="rpm"
> > -  RPM="rpm --nosignature"
> > +    RPM="rpm --nosignature"
> > -  RPM="rpm"
> > +    RPM="rpm"
> > -	$XAR tv "$1" | sed 's,^,-,;s, , 1 ,;s,/, ,'
> > +    $XAR tv "$1" | sed 's,^,-,;s, , 1 ,;s,/, ,'
> What the main idea for removing spaces is here?

To make indentation more consistent across extfs scripts
> 
> > -for dir in $PATH; do
> > +for dir in "$PATH"; do
> I think it's wrong.
> Consider two lines
>    aaa bbb
>    "aaa bbb"
> as for argument list.
> Imagine difference here.

Yep, my fault...
--
vda



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]