Re: extfs audio.in & hp48.in patch



q# wrote:
My practice with /bin/sh scripts is that the best solution with
functions that have many arguments is using "$@", with this you don't
lost special characters like spaces, etc.

You're right. It's a much better solution.

@@ -43,7 +43,7 @@
 then
     BASE=/dev/cdrom
 else
-    BASE=$2
+    BASE="$2"
 fi

This is not strictly necessary, but I left it in. I even enclosed the "/dev/cdrom" in quotes. (It's a string. Strings are enclosed in quotes.)

Patch committed. Thanks.

Roland



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]