Re: Re[2]: strip_passwd partial commit

[Jindrich Novy <jnovy redhat com>]

Hello Pavel,

On Tue, 2004-11-09 at 07:22, Pavel Shirshov (pchel) wrote:
> I got an output
> -----------------------------------------------------
> genie# ./mc
> pavelsh test ru:pass test your domain/path/to/file
> pavelsh test ru@test.your.domain
> pavelsh test ru:pass test your domain/path/to/file
> -------------------------
> pavelsh:pass test your domain/path/to/file
> pavelsh test your domain
> pavelsh test your domain/path/to/file
> -------------------------
> pavelsh test ru:pass test your domain/
> pavelsh test ru@test.your.domain
> pavelsh test ru:pass test your domain/
> -------------------------
> pavelsh test ru:pass test your domain/path/to/file/
> pavelsh test ru@test.your.domain
> pavelsh test ru:pass test your domain/path/to/file/
> -------------------------

Please note that the test case is valid only for URL present in string
txt2:

> pavelsh:pass test your domain/path/to/file
> pavelsh test your domain
> pavelsh test your domain/path/to/file

where the strip_password_new() behaves as it should (last line).

The rest of testing URLs are malformed, because they're not RFC-1738
compliant. So they *shouldn't* be used as URLs. Please see
http://www.faqs.org/rfcs/rfc1738.html section 3.1.

However, from the test case txt2 it's apparent the bug in the original
strip_password().

greetings,
Jindrich

-- 
Jindrich Novy <jnovy redhat com>, http://people.redhat.com/jnovy/