Re: [PATCH]: menu doesn't appear on right info panel

Hello Leonard,

On Tue, 2 Nov 2004, Leonard den Ottolander wrote:

> On Tue, 2004-11-02 at 11:51, Pavel Tsekov wrote:
> > Me and Pavel Shirshov both agree that this new patch is indeed better.
> > What I wrote in the mail describing the problem is based on me reading the
> > source code, but there aren't any comments or something else to proof
> > that I was right. The new code introduced by Pavel Rosking seemed to try
> > to avoid an endless loop too. I think the new code is clear, fool proof
> > and better.
> I don't say the new code is bad, I only wonder why you haven't checked
> the rest of the code to make sure whether your original statement about
> at least one item accepting WIDGET_CODE is correct. If that statement is

It would be a hard task to proof it - really. But I tell you - it worked
that way for quite some time :)

> true you have introduced a redundant check for a situation that will
> never occur.

No - we don't know what kind of a dialog would be introduced in the
future. And it is not indicated clearly that a dialog should have
at least one widget wich accepts focus.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]