Re: [PATCH]: menu doesn't appear on right info panel



Hello Pavel,

On Tue, 2004-11-02 at 11:51, Pavel Tsekov wrote:
> Me and Pavel Shirshov both agree that this new patch is indeed better.
> What I wrote in the mail describing the problem is based on me reading the
> source code, but there aren't any comments or something else to proof
> that I was right. The new code introduced by Pavel Rosking seemed to try
> to avoid an endless loop too. I think the new code is clear, fool proof
> and better.

I don't say the new code is bad, I only wonder why you haven't checked
the rest of the code to make sure whether your original statement about
at least one item accepting WIDGET_CODE is correct. If that statement is
true you have introduced a redundant check for a situation that will
never occur.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]