Re: [PATCH]: menu doesn't appear on right info panel

Hello Leonard,

On Tue, 2 Nov 2004, Leonard den Ottolander wrote:

> Hello Pavel,
> On Tue, 2004-11-02 at 10:10, Pavel Tsekov wrote:
> > Forgot to mention that this patch is better because it avoids
> > the risk of an endless loop.
> Yeah, pchel got this fear of an endless loop because of something you
> said in one of your mails. However, you wrote:
> "I get it that it is guaranteed to have at least one widget that accepts
> WIDGET_FOCUS. So an endless loop is unlikely to happen."
> If the above statement is true, then what is the need for this updated
> patch? Have you checked the code for the existence of a possible
> infinite loop? I haven't noticed it when testing the original patch. I
> somewhat have the feeling this new patch is redundant and pchel's fear
> is only based on a misunderstanding of what was written.

Me and Pavel Shirshov both agree that this new patch is indeed better.
What I wrote in the mail describing the problem is based on me reading the
source code, but there aren't any comments or something else to proof
that I was right. The new code introduced by Pavel Rosking seemed to try
to avoid an endless loop too. I think the new code is clear, fool proof
and better.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]