Re: Drawing errors

[Vladimir Nadvornik <nadvornik suse cz>]

On Tuesday 24 August 2004 17:35, Leonard den Ottolander wrote:
> Hello Jindrich,
>
> On Tue, 2004-08-24 at 16:59, Jindrich Makovicka wrote:
> > Leonard den Ottolander wrote:
> > > I am seeing drawing issues. As soon as I start mc I notice the straight
> > > line under the files is not terminated correctly. Yesterday I also
> > > noticed it being continued on the next line, and after toggling I now
> > > see that the last line "re-begins" halfway through.
> >
> > There's a off-by-one error in certain patched versions of SLang, at
> > least some RetHat versions and Debian versions. In Debian, it has been
> > finally fixed in latest unstable distribution.
>
> I was thinking slang might be involved. Could it cause these drawing
> errors? Can you provide more details? Where is this off by one located?
> Maybe you have a patch lying around?
>

It is probably this patch:

# Bug fix http://bugs.debian.org/192025
# off-by-one error when drawing horizontal lines
# 
diff -ruN slang-1.4.9-old/src/slsmg.c slang-1.4.9/src/slsmg.c
--- slang-1.4.9-old/src/slsmg.c 2004-06-25 10:20:57.000000000 +0100
+++ slang-1.4.9/src/slsmg.c     2004-06-25 10:11:09.000000000 +0100
@@ -1709,7 +1709,7 @@
    This_Color |= ALT_CHAR_FLAG;
    This_Col = cmin;
 
-   SLsmg_draw_object(This_Row, This_Col, ch);
+   // SLsmg_draw_object(This_Row, This_Col, ch);
    while (n-- > 0)
      {
        SLsmg_draw_object(This_Row, This_Col, ch);


-- 
Vladimir Nadvornik
developer
---------------------------------------------------------------------  
SuSE CR, s.r.o.                             e-mail: nadvornik suse cz
Drahobejlova 27                             tel:+420 2 9654 2373 
190 00 Praha 9                              fax:+420 2 9654 2374   
Ceska republika                             http://www.suse.cz