Re: Help fixes & Misc.

Hi, David!

Finally I had time to review the rest of your patch.

> c) Skip empty help nodes (with 'n' and similars). I found d)

The the fix is incomplete (doesn't skip those nodes when going backwards),
and most importantly, it doesn't belong here.  We need better help files.  
Not applied.

> d) Some fixes in help.c to avoid going past the end of the file with
> incorrect help files (improbable?).

I could reproduce this by truncating the help file and navigating it with 
"n".  A segfault on a wrong file is still a bug, so I applied your patch.

Pavel Roskin

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]